TRUNK-6284: Add discontinue_reason and discontinue_reason_non_coded t…#5998
TRUNK-6284: Add discontinue_reason and discontinue_reason_non_coded t…#59980abhi007 wants to merge 2 commits intoopenmrs:masterfrom
Conversation
|
Hi @dkayiwa @ibacher @mseaton @wikumChamith - could you please review this PR when you get a chance? This implements TRUNK-6284 - adds structured discontinuation reason support to the Order domain. Thank you! |
|
The implementation looks clean. |
jwnasambu
left a comment
There was a problem hiding this comment.
Kindly attach the correct ticket link on this PR please!
Thanks a lot for reviewing this, @vaalemax. I will double‑check copyHelper to ensure it safely handles a null discontinueReason to avoid any potential NPEs when copying discontinued Orders without a structured reason. I will also add unit tests covering the new discontinueReason and discontinueReasonNonCoded fields in the Order domain and update the PR accordingly. |
Thanks for the review, @jwnasambu. I have attached the correct ticket link here: |
|
jwnasambu
left a comment
There was a problem hiding this comment.
Thanks for the fix @0abhi007. Do you mind fixing your commit message please? Looking at this document https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips The summary/title of the pull request should contain the ticket's JIRA ID.
ibacher
left a comment
There was a problem hiding this comment.
Thanks for this. Feels like we could also use as simple test demonstrating this feature, probably in the OrderServiceTest.
|
|
||
|
|
||
|
|



Description of what I changed
JIRA: https://openmrs.atlassian.net/browse/TRUNK-6284?focusedCommentId=193037
Added
discontinue_reasonanddiscontinueReasonNonCodedfields to the Order domain object.discontinueReason(Concept) field to Order.javadiscontinueReasonNonCoded(String) field to Order.javaorderstableIssue I worked on
TRUNK-6284